Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete cmake/Platform/WASI.cmake #453

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcbhmr
Copy link

@jcbhmr jcbhmr commented Jul 18, 2024

CMake added CMAKE_SYSTEM_NAME="WASI" builtin! 🎉 https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9659
...(hopefully) as of CMake 3.31 🙄

Merge this whenever you bump the minimum CMake version to 3.31+ (which isn't even released yet 😅).

Unsure if there's any other CMAKE_MODULE_PATH stuff to remove that was using the Platform/WASI.cmake file?

@jcbhmr jcbhmr marked this pull request as draft July 18, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant