-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Web Audio API v1.1 FPWD #2603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catching up a bit, but I am happy with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
@padenot did you want to re-review, or ok to merge? |
There are some broken links:
|
If that's okay, I'd like to keep this PR is about removing mark-ups. On a follow up PR, I can fix all the broken links. |
Re @svgeesus:
|
It seems like this is now part of the HTML spec: https://html.spec.whatwg.org/multipage/canvas.html#2dcontext Should we replace the reference with [HTML] instead? |
I am not sure if that's a helpful change. If that's the only solution, linking "Canvas 2D" to the entire HTML spec is a bit misleading I guess? I think the W3C link checker is a bit aggressive. It also complains about the document fragment ( |
It complains if it can't find the specific fragment in that document. However it doesn't run JS on fetched resources so is vulnerable to false negatives. |
We can add a local bibliography that defines [2DContext] and links to https://html.spec.whatwg.org/#2dcontext specref should also be updated, but we don't have to be blocked on that. |
This PR is to publish FPWD of Web Audio API v1.1. The change includes followings:
decodeAudioData
isn't specified #2375References
Preview | Diff