Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Web Audio API v1.1 FPWD #2603

Merged
merged 10 commits into from
Oct 4, 2024
Merged

Publish Web Audio API v1.1 FPWD #2603

merged 10 commits into from
Oct 4, 2024

Conversation

hoch
Copy link
Member

@hoch hoch commented Sep 27, 2024

@hoch hoch requested review from padenot, mdjp and svgeesus September 27, 2024 00:06
@hoch hoch self-assigned this Sep 27, 2024
Copy link
Contributor

@mjwilson-google mjwilson-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

index.bs Outdated Show resolved Hide resolved
Copy link
Member

@mdjp mdjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching up a bit, but I am happy with this.

@hoch hoch requested a review from padenot October 2, 2024 17:34
@hoch
Copy link
Member Author

hoch commented Oct 2, 2024

@padenot @svgeesus PTAL again!

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@svgeesus
Copy link
Contributor

svgeesus commented Oct 2, 2024

@padenot did you want to re-review, or ok to merge?

@svgeesus
Copy link
Contributor

svgeesus commented Oct 2, 2024

There are some broken links:

@hoch
Copy link
Member Author

hoch commented Oct 2, 2024

If that's okay, I'd like to keep this PR is about removing mark-ups. On a follow up PR, I can fix all the broken links.

@mjwilson-google
Copy link
Contributor

[2dcontext] in spec ref is pointing an invalid link (404). Perhaps we can remove this link from the spec?

It seems like this is now part of the HTML spec: https://html.spec.whatwg.org/multipage/canvas.html#2dcontext

Should we replace the reference with [HTML] instead?

@hoch
Copy link
Member Author

hoch commented Oct 4, 2024

I am not sure if that's a helpful change. If that's the only solution, linking "Canvas 2D" to the entire HTML spec is a bit misleading I guess?

I think the W3C link checker is a bit aggressive. It also complains about the document fragment (#). Not sure why this is not allowed.

@svgeesus
Copy link
Contributor

svgeesus commented Oct 4, 2024

I think the W3C link checker is a bit aggressive. It also complains about the document fragment (#). Not sure why this is not allowed.

It complains if it can't find the specific fragment in that document.

However it doesn't run JS on fetched resources so is vulnerable to false negatives.

@svgeesus svgeesus merged commit 2696242 into main Oct 4, 2024
1 check passed
@svgeesus svgeesus deleted the fpwd-prep branch October 4, 2024 17:11
@svgeesus
Copy link
Contributor

svgeesus commented Oct 4, 2024

I am not sure if that's a helpful change. If that's the only solution, linking "Canvas 2D" to the entire HTML spec is a bit misleading I guess?

We can add a local bibliography that defines [2DContext] and links to https://html.spec.whatwg.org/#2dcontext

specref should also be updated, but we don't have to be blocked on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolution: publish a new FPWD as version 1.1
5 participants