Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect fix in PR #882 #922

Closed
pfeairheller opened this issue Jan 9, 2025 · 1 comment · Fixed by #923
Closed

Incorrect fix in PR #882 #922

pfeairheller opened this issue Jan 9, 2025 · 1 comment · Fixed by #923

Comments

@pfeairheller
Copy link
Member

The fix to completely remove contact creation in OOBI resolution in PR #882 was incorrect. The previous code that was changed allowed for OOBI resolution that does not effect the contact by not providing an alias during resolution. Upstream code should be changed to use OOBI resolution correctly instead of removing behavior from KERIpy.

@iFergal
Copy link
Contributor

iFergal commented Jan 9, 2025

That's fair, can just strip the alias from the URL in the upstream code.

A smaller motivation for #882 was just to have a clear separation, and I thought there was a long term plan to slim keripy down to core functionality that might not include contact management. (and have contact management as another helper package or something)

Happy with whichever way though, I can adjust to strip the alias from the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants