You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fix to completely remove contact creation in OOBI resolution in PR #882 was incorrect. The previous code that was changed allowed for OOBI resolution that does not effect the contact by not providing an alias during resolution. Upstream code should be changed to use OOBI resolution correctly instead of removing behavior from KERIpy.
The text was updated successfully, but these errors were encountered:
That's fair, can just strip the alias from the URL in the upstream code.
A smaller motivation for #882 was just to have a clear separation, and I thought there was a long term plan to slim keripy down to core functionality that might not include contact management. (and have contact management as another helper package or something)
Happy with whichever way though, I can adjust to strip the alias from the URL.
The fix to completely remove contact creation in OOBI resolution in PR #882 was incorrect. The previous code that was changed allowed for OOBI resolution that does not effect the contact by not providing an alias during resolution. Upstream code should be changed to use OOBI resolution correctly instead of removing behavior from KERIpy.
The text was updated successfully, but these errors were encountered: