Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OOBI contact generation #923

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

pfeairheller
Copy link
Member

This PR fixes #922 by reintroducing contact creation since it is optional. It also includes a few minor logging fixes.

Signed-off-by: pfeairheller <pfeairheller@gmail.com>
Signed-off-by: pfeairheller <pfeairheller@gmail.com>
@pfeairheller pfeairheller merged commit 2f69121 into WebOfTrust:main Jan 12, 2025
6 checks passed
@pfeairheller pfeairheller deleted the feat-fix-oobis branch January 12, 2025 23:21
@kentbull
Copy link
Contributor

From one of our calls we discussed changing:

self.org.replace(pre=obr.cid, data=dict(alias=obr.oobialias, oobi=url))

to

self.org.update(pre=obr.cid, data=dict(alias=obr.oobialias, oobi=url))

Because Organizer.update() performs a Organizer.replace() if the contact data doesn't exist yet if it does exist then it performs a merge, which is what Fergal was after anyway. What was causing people problems is that `Organizer.replace() wipes out any contact data that is there, which will always erase any aliases you have for someone if you re-oobi with them without specifying the alias.

I'll open up A PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect fix in PR #882
2 participants