-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: IPEX apply, offer, agree #272
feat: IPEX apply, offer, agree #272
Conversation
* feat: IPEX apply, offer, admit msgs * test: apply, offer, agree integration tests * fix: correct typing * test: ipex unit tests * test: improve test and docs * test: ipex better split of unit tests * test: whitespace diff
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
+ Coverage 83.82% 83.93% +0.10%
==========================================
Files 48 48
Lines 4229 4257 +28
Branches 1034 1051 +17
==========================================
+ Hits 3545 3573 +28
Misses 656 656
Partials 28 28 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One thing to consider in the IpexXXXArgs interfaces is if we should be more descriptive in the property names for grant/apply/offer etc... So:
interface IpexAdmitArgs {
grantSaid: string
]
What do you reckon?
thanks, agreed @lenkan I also changed it to |
@lenkan can this be merged, or awaiting review from @rodolfomiranda? I couldn't make the dev call |
I think we can merge it now. No one seems to have any objections. |
Apply, offer, agree IPEX messages. Covers single and multi-sig as multi-sig is just a normal
/ipex/*
message (multi-signed) embedded in/multisig/exn
.On the recipient field:
rp
(to be renamed tori
) is all that's needed in exn messages, so recipient always specifieda.i
- so I haven't removed the code that auto adds this based on the recipient fieldrp
/ri
fully we can remove it from Signify.The
recp
field can still be removed on KERIA but that isn't needed for this PR.