Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: IPEX apply, offer, agree #272

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

iFergal
Copy link
Contributor

@iFergal iFergal commented Jul 30, 2024

Apply, offer, agree IPEX messages. Covers single and multi-sig as multi-sig is just a normal /ipex/* message (multi-signed) embedded in /multisig/exn.

On the recipient field:

  • rp (to be renamed to ri) is all that's needed in exn messages, so recipient always specified
  • no extra harm in including a.i - so I haven't removed the code that auto adds this based on the recipient field
    • once keripy has moved to rp/ri fully we can remove it from Signify.
    • for now, less likely to break things this way.

The recp field can still be removed on KERIA but that isn't needed for this PR.

iFergal added 5 commits July 29, 2024 09:34
* feat: IPEX apply, offer, admit msgs

* test: apply, offer, agree integration tests

* fix: correct typing

* test: ipex unit tests

* test: improve test and docs

* test: ipex better split of unit tests

* test: whitespace diff
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.93%. Comparing base (850af59) to head (fe0dbe8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
+ Coverage   83.82%   83.93%   +0.10%     
==========================================
  Files          48       48              
  Lines        4229     4257      +28     
  Branches     1034     1051      +17     
==========================================
+ Hits         3545     3573      +28     
  Misses        656      656              
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One thing to consider in the IpexXXXArgs interfaces is if we should be more descriptive in the property names for grant/apply/offer etc... So:

interface IpexAdmitArgs {
   grantSaid: string
]

What do you reckon?

@iFergal
Copy link
Contributor Author

iFergal commented Aug 12, 2024

thanks, agreed @lenkan I also changed it to schemaSaid since it only works with SAIDs right now

@iFergal
Copy link
Contributor Author

iFergal commented Aug 14, 2024

@lenkan can this be merged, or awaiting review from @rodolfomiranda? I couldn't make the dev call

@lenkan
Copy link
Collaborator

lenkan commented Aug 14, 2024

I think we can merge it now. No one seems to have any objections.

@lenkan lenkan merged commit 1212b54 into WebOfTrust:main Aug 14, 2024
8 checks passed
@iFergal iFergal deleted the feat/applyOfferAdmitIpex branch August 14, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants