Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ DocumentFragment.textContent #278

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

+ DocumentFragment.textContent #278

wants to merge 3 commits into from

Conversation

iacore
Copy link

@iacore iacore commented Jun 9, 2024 •
edited
Loading

fix #231

@WebReflection
Copy link
Owner

WebReflection commented Jun 9, 2024 •
edited
Loading

There is no test, please add one, thanks. never mind, I've seen tests now ...

@iacore iacore marked this pull request as draft June 9, 2024 19:40
@iacore
Copy link
Author

iacore commented Jun 9, 2024 •
edited
Loading

the plot thickens. i may end up adding more features.

@WebReflection
Copy link
Owner

I am not going to Approve and run until this is draft ... please let me know when this is not draft anymore, thanks!

@iacore iacore marked this pull request as ready for review June 12, 2024 09:42
@iacore
Copy link
Author

iacore commented Jun 12, 2024 •
edited
Loading

So, I discovered another bug that I don't know how to fix. Can you fix it? I've added a test for it.

@WebReflection
Copy link
Owner

I am not sure I know what bug you are talking about ... but if it has nothing to do with textContent it should likely not be part of this PR?

@iacore
Copy link
Author

iacore commented Jun 12, 2024 •
edited
Loading

fixed it. moved it to #279.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebReflection WebReflection WebReflection left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

null textContent value for DocumentFragment
2 participants
@iacore @WebReflection