Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Sinitic languages and script names #1427

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

winstonsung
Copy link
Contributor

@winstonsung winstonsung commented Aug 24, 2024

closes #1410
closes #1411

Bug: #1410
Bug: #1411
Change-Id: Ibc4e7802d6a331511792da37824378074722c5c0

Proposed changes

  • Use "language name (script/orthography name)" instead of "Chinese (language name, script/orthography name)"
  • Add Sinitic languages
  • Add Formosan languages (Taiwanese aboriginal languages)
  • Split gan into gan-Hans, gan-Hant
  • Split hak into hak-Hans, hak-Hant, hak-Latn

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

- Use "language name (script/orthography name)" instead of "Chinese (language name, script/orthography name)"
- Add Sinitic languages
- Add Formosan languages (Taiwanese aboriginal languages)
- Split gan into gan-Hans, gan-Hant
- Split hak into hak-Hans, hak-Hant, hak-Latn

closes WeblateOrg#1410
closes WeblateOrg#1411

Bug: WeblateOrg#1410
Bug: WeblateOrg#1411
Change-Id: Ibc4e7802d6a331511792da37824378074722c5c0
@nijel nijel merged commit 0292834 into WeblateOrg:main Aug 26, 2024
10 checks passed
@nijel
Copy link
Member

nijel commented Aug 26, 2024

Merged, thanks for your contribution!

@nijel nijel self-assigned this Aug 26, 2024
@winstonsung winstonsung deleted the dev-1427 branch August 26, 2024 11:38
@winstonsung
Copy link
Contributor Author

@nijel wrote:
Pull requests are welcome! Master language definitions are at https://github.com/WeblateOrg/language-data/blob/main/languages.csv

Thanks. However, not all

weblate_language_data\locale\*\LC_MESSAGES\django.po

files were updated when using

make

(especially for those language tag with underscores), any ideas about the issue (or is it intended)?

@nijel
Copy link
Member

nijel commented Aug 26, 2024

There was missing alias for hak, I've added it in d8b763a to hak_Hant. Please correct that if it's wrong.

As for missed updates, it should be fixed by 4458b61, thanks for spotting!

@winstonsung
Copy link
Contributor Author

There was missing alias for hak, I've added it in d8b763a to hak_Hant. Please correct that if it's wrong.

It's correct. Thanks.

As for missed updates, it should be fixed by 4458b61, thanks for spotting!

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants