Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Rework naming convention and status description requirements #118

Merged
merged 32 commits into from
Dec 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e06d02a
Alphabetize some title series by changing names of their markdown files
mattmaniak Oct 30, 2024
666225b
Rename title source files and limit their abbreviation possibilities …
mattmaniak Oct 30, 2024
1045fc5
Merge branch 'Whisky-App:main' into main
mattmaniak Oct 31, 2024
0cfaa50
Resignate from any acronyms as they mess up ordering a lot; match som…
mattmaniak Nov 1, 2024
7784aa4
Match file and game names with the Steam ones
mattmaniak Nov 1, 2024
50cb158
Add info about Fear and Hunger visibility on Steam
mattmaniak Nov 1, 2024
3c36e09
Move all the game issues under "[>WARNING]" heading
mattmaniak Nov 1, 2024
8b6304b
Add dots at the end of an example list items
mattmaniak Nov 1, 2024
eaaf57c
Add proper alt text for example Whisky page screenshot
mattmaniak Nov 1, 2024
5b41895
Organize warnings and issues for a rest of games
mattmaniak Nov 1, 2024
c060634
Merge branch 'main' of https://github.com/Whisky-App/whisky-book
mattmaniak Nov 6, 2024
24e6d7c
Merge branch 'main' of https://github.com/Whisky-App/whisky-book
mattmaniak Nov 7, 2024
083a314
Fix game markdown files abbrevations into a full names for newly adde…
mattmaniak Nov 7, 2024
f79d1e7
Merge branch 'Whisky-App:main' into main
mattmaniak Nov 16, 2024
b198146
Merge branch 'main' of https://github.com/Whisky-App/whisky-book
mattmaniak Nov 16, 2024
cab4d51
Update Hotline Miami series with a full markdown files names
mattmaniak Nov 16, 2024
3c9b433
Merge branch 'main' of https://github.com/Whisky-App/whisky-book
mattmaniak Nov 18, 2024
41bab68
Update Tomb Rider 1-3 markdown file name and fix typos
mattmaniak Nov 18, 2024
6af3e23
Merge branch 'main' of https://github.com/Whisky-App/whisky-book
mattmaniak Nov 21, 2024
4a6c2d5
Match The Binding of Isaac: Repetance+ name with Steam
mattmaniak Nov 21, 2024
25fbe9c
Merge branch 'main' of https://github.com/Whisky-App/whisky-book
mattmaniak Nov 25, 2024
8ae9da8
Update Little Big Adventure markdown file name
mattmaniak Nov 25, 2024
97afc23
Update Little Big Adventure game formatting to match our standards
mattmaniak Nov 25, 2024
e2d756c
Merge branch 'main' of https://github.com/Whisky-App/whisky-book
mattmaniak Nov 27, 2024
44eb269
Update Age of Empires II markdown file name with new standards
mattmaniak Nov 27, 2024
3eb6cd3
Merge branch 'main' of https://github.com/Whisky-App/whisky-book
mattmaniak Dec 5, 2024
9ff772f
Match Sins of a Solar Empire II name with Steam
mattmaniak Dec 5, 2024
8231b70
Merge branch 'main' of https://github.com/Whisky-App/whisky-book
mattmaniak Dec 16, 2024
956aad8
Update Path of Exile 2 markdown filename
mattmaniak Dec 16, 2024
0a4ed57
Minor grammar fixes
hahayupgit Dec 28, 2024
014bc00
Merge branch 'main' into pr/118
hahayupgit Dec 28, 2024
de8bfbe
generate summary
hahayupgit Dec 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Documentation for Whisky.
- Ensure accuracy. Don't upload misleading information, false reports, guesses, or improper research.
- Cite your sources. Found a guide from somewhere else? Found a solution or other thing online? Provide a link in your page. This isn't a requirement that's going to get your PR rejected, but simply one that future-proofs things and ensures that if a game suddenly breaks, we can check our sources and see if there are any updates to the solutions found.
- Document the installation process and any errors that arise during the installation. If installation fails, set `installs=No` in the `Ratings` template.
- Document whether a program opens by setting `opens=Yes` in the `Ratings` template. A program is considered "open" if it launches the title screen or main menu. Dialog messages don't count as a program "opening".
- Document whether a program opens by setting `opens=Yes` in the `Ratings` template. A program is considered "open" if it launches the title screen or main menu. Dialog messages don't count as a program "opening". Write down all issues that you have noticed while playing a title under a `> [!WARNING]` heading.
- Add status ratings to your game based on the following scale. We leave this up to general author interpretation, but please make sure you're still following these general guidelines:

| Status | Description |
Expand All @@ -44,14 +44,16 @@ Documentation for Whisky.
| Garbage | Game is unplayable. |

1. Create a new markdown file in `~/whisky-book/src/game-support` with the name of the game.
- Format your file in all lowercase, using only alphabetical, numerical, and dash characters, and use abbreviations where possible. i.e:
- Format your file in all lowercase, using only alphabetical, numerical, and dash characters. Do not use abbreviations as they mess up titles ordering with an exception of `goty` which stands for "Game of the Year" and is used among many titles and known as a standard. Use a dash sign (`-`) everytime a space occurs in the original title. Replace roman numerals with arabic ones to distinguish words from numbers. Do not insert any [articles](https://www.grammarly.com/blog/parts-of-speech/articles/) in a markdown file name (`a`, `the`). Remember to match a filename with a full game title (eg. from Steam) using above exceptions and restrictions. If a game is not listed on Steam then add the store/page name at the very end of the file like `<some-game>-gog` i.e:
```
Metal Gear Solid V: The Phantom Pain -> mgs-5.md
Persona 3 Reload -> p3r.md
Star Wars Jedi: Fallen Order -> sw-fallen-order.md
Geometry Wars 3: Dimensions Evolved -> gw3-dimensions-evolved.md
Diablo IV (Battle.net) -> diablo-4-battle-net
Geometry Wars 3: Dimensions Evolved -> geomatry-wars-3-de.md
Metal Gear Solid V: The Phantom Pain -> metal-gear-solid-5-phantom-pain.md
Persona 3 Reload -> persona-3-reload.md
Star Wars Jedi: Fallen Order -> star-wars-jedi-fo.md
Wolfenstein II: The New Colossus -> wolfenstein-2-new-colossus.md
```
2. Add the following template to your markdown file.
2. Add the following template to your markdown file. Ensure that the game name you enter at the beginning of the file matches Steam or other store listing name fully, including capitalization. However remove any character that is not an ASCII printable character. You can find the allowed characters list [here](https://www.ascii-code.com/characters/printable-characters).
```
# <Full Game Name Here>

Expand All @@ -69,13 +71,13 @@ Documentation for Whisky.

## Setup

- Install in Steam as normal
- In Whisky, find `SwGame-Win64-Shipping.exe` in the Program list and run it
- Install in Steam as normal.
- In Whisky, find `SwGame-Win64-Shipping.exe` in the Program list and run it.

{{#template ../templates/steam.md id=1172380}}

```
<img width="815" alt="Screenshot 2024-04-16 at 10 06 11 PM" src="https://github.com/Whisky-App/whisky-book/assets/161992562/d7d61b1a-5d02-4961-8ff5-b953c2a2fbe1">
<img width="815" alt="Preview of Star Wars Jedi: Fallen Order Whisky documentation page" src="https://github.com/Whisky-App/whisky-book/assets/161992562/d7d61b1a-5d02-4961-8ff5-b953c2a2fbe1">
3. Run the `generate` script with `./scripts/generate.mjs` to update `SUMMARY.md`.
This will also make the game appear in the sidebar of the book.
4. Run `./scripts/lint.mjs` to ensure that your changes are properly formatted.
Expand Down
Loading
Loading