Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Against The Storm #136

Merged
merged 7 commits into from
Jan 2, 2025
Merged

Added support for Against The Storm #136

merged 7 commits into from
Jan 2, 2025

Conversation

tsainez
Copy link
Contributor

@tsainez tsainez commented Nov 25, 2024 •
edited by hahayupgit
Loading

Description

This pull request adds documentation for support for the game "Against The Storm."

Type(s)

  • Game page addition

Verification

Have you

  • Followed the contribution guidelines?
  • Ran ./scripts/generate.mjs?
  • Ran ./scripts/lint.mjs?
  • Checked spelling and grammar?
  • (If applicable) Provided documentation for a game not working? (i.e. detailing what happens when the game doesn't work?)
  • (If applicable) Ensured the linked Steam ID is the correct one for your game addition?

@mattmaniak
Copy link
Member

mattmaniak commented Nov 25, 2024 •
edited
Loading

What's the need of <> signs around the title? I don't see their presence of Steam page nor when googling the game.

@tsainez
Copy link
Contributor Author

tsainez commented Nov 25, 2024

I'm not sure why, but when I run the generate script the &lt; gets added.

mattmaniak
mattmaniak requested changes Nov 25, 2024
View reviewed changes
Copy link
Member

@mattmaniak mattmaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the <> signs from the title name and run ./scripts again as there is no point to include such characters in the title.

@tsainez
Copy link
Contributor Author

tsainez commented Nov 27, 2024

I have committed a change that removes the brackets from the text.

@mattmaniak
Copy link
Member

It removes brackets only from the Summary.md file. Please do it in the game page and run scripts again.

@hahayupgit hahayupgit requested a review from mattmaniak January 2, 2025 20:45
@hahayupgit hahayupgit merged commit 58c218a into Whisky-App:main Jan 2, 2025
1 check passed
hahayupgit added a commit that referenced this pull request Jan 2, 2025
@tsainez @hahayupgit
docs: Added support for Against The Storm (#136)
58c218a 
* Added support for Against The Storm

* Remove brackets from text

* Fix naming

* Update SUMMARY.md

---------

Co-authored-by: logan <hahayupbiz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hahayupgit hahayupgit hahayupgit approved these changes

@mattmaniak mattmaniak mattmaniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsainez @mattmaniak @hahayupgit