Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add The Binding of Isaac: Repentance #67

Merged
merged 9 commits into from
Aug 23, 2024

Conversation

SheldonCoulson99
Copy link
Contributor

Add The Binding of Isaac: Repentance as fully playable.
Tested on Version 2.3.2 (40)

Copy link
Member

@mattmaniak mattmaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alias looks the same as the title. Did you mean an alias without ":" in it?

@SheldonCoulson99
Copy link
Contributor Author

An alias looks the same as the title. Did you mean an alias withou ":" in it?

Ah, yes. I've changed it now in a new commit.

Copy link
Member

@mattmaniak mattmaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok now.

@hahayupgit
Copy link
Member

hahayupgit commented Aug 23, 2024

@SheldonCoulson99 can you please confirm that Repentance only works by launching isaac-ng.exe directly? I don't own Repentance personally but I own TBOI: Rebirth, and the game launches directly through Steam in Whisky, and as far as I can tell Repentance is just a DLC for Rebirth.

If so, just let me know. Otherwise, looks good & is ready to merge.

@SheldonCoulson99
Copy link
Contributor Author

@SheldonCoulson99 can you please confirm that Repentance only works by launching isaac-ng.exe directly? I don't own Repentance personally but I own TBOI: Rebirth, and the game launches directly through Steam in Whisky, and as far as I can tell Repentance is just a DLC for Rebirth.

If so, just let me know. Otherwise, looks good & is ready to merge.

Yes, both via steam in whisky and directly launching isaac-ng.exe works.
I just thought that since launching isaac-ng.exe will also launch steam. So I guess this way can make the player's life easier. 😄

@hahayupgit
Copy link
Member

Ahh I see! Thank you for letting me know. I'm going to remove that portion of the documentation, since it launches through Steam, as we detail how to pin programs at a different place in the docs. But thank you so much for your additions! We greatly appreciate it.

@hahayupgit hahayupgit merged commit e20b972 into Whisky-App:main Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants