Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a rule to suggest constructor injection over Provides method #20

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WhosNickDoglio
Copy link
Owner

@WhosNickDoglio WhosNickDoglio commented Apr 8, 2023

Description

Related Issue

Motivation and Context

Implementation Summary

Checklist

  • My code follows the style guidelines of this project (gradlew detektAll)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I hae mentioned changes in CHANGELOG.md.
  • I have read the CONTRIBUTING document.

@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.88%. Comparing base (c8e49c7) to head (56eed20).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
...ectors/ConstructorInjectionOverProvidesDetector.kt 73.91% 5 Missing and 1 partial ⚠️
.../whosnickdoglio/dagger/DaggerRulesIssueRegistry.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   89.47%   88.88%   -0.59%     
==========================================
  Files          21       22       +1     
  Lines         741      765      +24     
  Branches       82       85       +3     
==========================================
+ Hits          663      680      +17     
- Misses         50       56       +6     
- Partials       28       29       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch from 19b696b to e0f4700 Compare April 13, 2023 15:39
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch from e0f4700 to 25ae451 Compare April 30, 2023 20:30
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch from e26732a to dd1a80a Compare January 3, 2024 13:40
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch 3 times, most recently from f64be0a to 23d5dd1 Compare April 6, 2024 15:26
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch 2 times, most recently from 9249bd4 to 3336cae Compare April 20, 2024 13:13
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch from 3336cae to bd05c6f Compare April 27, 2024 19:58
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch 2 times, most recently from 41c125f to caec8ce Compare June 1, 2024 03:28
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch 2 times, most recently from e7e821e to 4c5831f Compare June 14, 2024 01:52
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch 3 times, most recently from 876986e to 64d2d42 Compare July 13, 2024 14:31
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch from 64d2d42 to 6bf780f Compare July 28, 2024 12:45
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch from 6bf780f to 8ebeeb8 Compare August 25, 2024 15:57
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch 2 times, most recently from 5db7695 to e7cbf84 Compare September 13, 2024 23:59
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch from e7cbf84 to 06b77cb Compare October 19, 2024 02:58
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch 2 times, most recently from d90f90f to 45433f3 Compare November 2, 2024 16:30
Copy link
Contributor

github-actions bot commented Nov 2, 2024

Warnings
⚠️

Any major changes should be added to our CHANGELOG.md file
Changelog format is based on Keep a Changelog.

Generated by 🚫 Danger Kotlin against 56eed20

@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch from 45433f3 to 56eed20 Compare November 16, 2024 20:58
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch 2 times, most recently from d182042 to 56eed20 Compare January 10, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant