Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ComponentMustBeAbstractDetector aware of Anvil Component annotations #260

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

WhosNickDoglio
Copy link
Owner

@WhosNickDoglio WhosNickDoglio commented Apr 21, 2024

Description

Related Issue

Checklist

  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have mentioned changes in CHANGELOG.md.
  • I have read the CONTRIBUTING document.

PR Stack

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (72c0e67) to head (c603bb3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   89.38%   89.47%   +0.09%     
==========================================
  Files          20       20              
  Lines         678      684       +6     
  Branches       72       72              
==========================================
+ Hits          606      612       +6     
  Misses         49       49              
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WhosNickDoglio WhosNickDoglio force-pushed the annotations-shared branch 3 times, most recently from ec3097e to 88d6b1e Compare June 29, 2024 16:23
Base automatically changed from annotations-shared to main September 11, 2024 15:39
@WhosNickDoglio WhosNickDoglio force-pushed the dagger-aware branch 2 times, most recently from 2145a0e to cb3a40e Compare September 12, 2024 14:47
@WhosNickDoglio WhosNickDoglio marked this pull request as ready for review September 12, 2024 15:07
@WhosNickDoglio WhosNickDoglio merged commit 905524b into main Sep 12, 2024
13 checks passed
@WhosNickDoglio WhosNickDoglio deleted the dagger-aware branch September 12, 2024 15:24
WhosNickDoglio added a commit that referenced this pull request Sep 13, 2024
…ions (#260)

## Description

<!--- Describe your changes in detail -->

## Related Issue

<!--- This project only accepts pull requests related to open issues -->

<!--- If suggesting a new feature or change, please discuss it in an
issue first -->

<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->

<!--- Please link to the issue here: -->

## Checklist

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->

<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have mentioned changes in [CHANGELOG.md](../CHANGELOG.md).
- [ ] I have read the [**CONTRIBUTING**](CONTRIBUTING.md) document.

## PR Stack

<!-- branch-stack -->

- `main`
  - \#260 :point\_left:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant