Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revalidar receipt #95

Merged
merged 14 commits into from
Sep 1, 2021
Merged

Revalidar receipt #95

merged 14 commits into from
Sep 1, 2021

Conversation

juanpsenn
Copy link
Contributor

@juanpsenn juanpsenn commented Aug 26, 2021 •
edited
Loading

Se implementa revalidate() para dar soporte al issue #92. Ademas se contemplan los 3 casos de prueba descriptos.

Aclaraciones

  • Se utilizo un procedimiento similar al _validate() para registrar las ReceiptValidations (cambian algunos nombres de atributos)
  • FECompConsultar da error si el comprobante no existe en AFIP, por lo que tuve que capturar la excepcion (abierto a sugerencias)

juanpsenn
juanpsenn commented Aug 26, 2021
View reviewed changes
WhyNotHugo
WhyNotHugo requested changes Aug 26, 2021
View reviewed changes
WhyNotHugo
WhyNotHugo reviewed Aug 27, 2021
View reviewed changes
Copy link
Owner

@WhyNotHugo WhyNotHugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se ve bien. Podés agregarlo al changelog para la versión 9.0.0?

Thanks!

WhyNotHugo
WhyNotHugo approved these changes Sep 1, 2021
View reviewed changes
Copy link
Owner

@WhyNotHugo WhyNotHugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se ve okay. Tengo un solo comentario final, y ya podemos mergear esto.

Thanks! 👍

WhyNotHugo
WhyNotHugo reviewed Sep 1, 2021
View reviewed changes
@WhyNotHugo WhyNotHugo merged commit 9c993d5 into WhyNotHugo:main Sep 1, 2021
@WhyNotHugo WhyNotHugo mentioned this pull request Sep 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhyNotHugo WhyNotHugo WhyNotHugo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanpsenn @WhyNotHugo