Fix save_on_teleport_event does not work #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiIIiam278
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guard function of
(!back.isSaveOnTeleportEvent() || back.canReturnToWorld(sourcePosition.getWorld()))logic looks strange. It means that when the setting is enable or the can be return, then setLastPosition will not be trigger.This changes make sure save_on_teleport_event and can return to world both true then trigger the setLastPosition.
Tested in purpur-1.21.4-2408 release 4.9.5 cannot save vanilla TP for /back , with this commit it works.
Solve #813