Empty state illustartions #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Padding in category item and file usage item
Updated Fragment_media_details
add search feature in the explore tab (WikiEducationFoundation#282)
Refactor All DI modules inside a Modules.kt file (WikiEducationFoundation#299)
|
Those are texts, if possible we will like illustrations for empty state in place of these texts. |
|
Do you have those Illustrations? |
|
Yes. We need images for that. I don't have the images. We need to search/design them. |
|
Please send if you have that |
|
Till then Please merge these changes |
ujjwalagrawal17
requested changes
Jan 11, 2020
...org/wikiedufoundation/wikiedudashboard/ui/coursedetail/uploads/view/CourseUploadsFragment.kt
Outdated
Show resolved
Hide resolved
...org/wikiedufoundation/wikiedudashboard/ui/coursedetail/uploads/view/CourseUploadsFragment.kt
Show resolved
Hide resolved
victorvicari
requested changes
Jan 13, 2020
|
But Its working correctly |
|
On other fragments also there is same type of null check using run |
|
Okay, I will check and get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #269
Added Empty State Illustrations for existing pages
(My Profile Page) Contribution Tab
(My Profile Page) Course Tab:
(My Profile Page) Recent Uploads Tab
Screenshots
Before:
After:
Other pages mentioned in issue had already the empty illustrations