Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty state illustartions #303

Merged
merged 14 commits into from
Jan 28, 2020
Merged

Empty state illustartions #303

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b105ea0
Updated Fragment_media_details
Darshpreet2000 Nov 27, 2019
43e1752
Merge pull request #1 from Darshpreet2000/Darshpreet2000-patch-1
Darshpreet2000 Nov 27, 2019
1ef851a
Merge pull request #2 from WikiEducationFoundation/master
Darshpreet2000 Jan 5, 2020
e2291f0
Merge pull request #3 from WikiEducationFoundation/master
Darshpreet2000 Jan 8, 2020
0740109
SplashScreen test
Darshpreet2000 Jan 8, 2020
78f3848
Updated
Darshpreet2000 Jan 8, 2020
d4bd0e9
Refactor All DI modules inside a Modules.kt file
Darshpreet2000 Jan 8, 2020
25f9cba
Converted PresenterCallback from java to Kotlin
Darshpreet2000 Jan 8, 2020
9a08349
changed
Darshpreet2000 Jan 8, 2020
a8ac181
Update SplashScreenTest.java
Darshpreet2000 Jan 9, 2020
de9a248
Merge branch 'master' into master
Darshpreet2000 Jan 9, 2020
bbd8f26
Added Empty State Illustration
Darshpreet2000 Jan 9, 2020
5076993
Merge pull request #5 from WikiEducationFoundation/master
Darshpreet2000 Jan 9, 2020
193742c
Changed checking from null to run
Darshpreet2000 Jan 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .../wikiedufoundation/wikiedudashboard/ui/coursedetail/uploads/view/CourseUploadsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ class CourseUploadsFragment : Fragment(), CourseUploadsView {
courseUrl?.let { courseUploadsPresenter.requestCourseUploads(it) }
} else if (type == 2) {
courseUploadList?.let { setData(it) }
if(courseUploadList==null){
ujjwalagrawal17 marked this conversation as resolved.
Show resolved Hide resolved

recyclerUploadList?.visibility = View.GONE
textViewNoUploads?.visibility = View.VISIBLE
}
showProgressBar(false)
}
}
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/layout/fragment_explore_course_list.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
android:gravity="center"
android:text="@string/tv_no_courses"
android:visibility="gone"
android:textSize="@dimen/text_size_20sp"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintLeft_toLeftOf="parent"
app:layout_constraintRight_toRightOf="parent"
Expand Down
28 changes: 16 additions & 12 deletions app/src/main/res/layout/fragment_profile_stats.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,24 @@
android:layout_height="match_parent"
xmlns:app="http://schemas.android.com/apk/res-auto">


<androidx.constraintlayout.widget.ConstraintLayout
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_height="match_parent"
tools:context="org.wikiedufoundation.wikiedudashboard.ui.profile.view.ProfileStatsFragment">

<TextView
android:layout_marginTop="200dp"
app:layout_constraintTop_toTopOf="parent"
android:id="@+id/tvNotEnrolled"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:visibility="gone"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintLeft_toLeftOf="parent"
app:layout_constraintRight_toRightOf="parent"
android:textSize="@dimen/text_size_20sp"
android:text="@string/not_enrolled" />

<androidx.constraintlayout.widget.ConstraintLayout
android:id="@+id/clByStudent"
Expand Down Expand Up @@ -160,6 +172,7 @@


</androidx.constraintlayout.widget.ConstraintLayout>

<androidx.constraintlayout.widget.ConstraintLayout
android:id="@+id/clAsStudent"
android:layout_width="match_parent"
Expand Down Expand Up @@ -331,16 +344,7 @@
android:padding="@dimen/padding_8dp"
android:text="@string/commons_upload" />

<TextView
android:id="@+id/tvNotEnrolled"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center"
android:textSize="@dimen/text_size_20sp"
app:layout_constraintLeft_toLeftOf="parent"
app:layout_constraintRight_toRightOf="parent"
app:layout_constraintTop_toBottomOf="@id/common_uploads"
android:text="@string/not_enrolled" />


</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/layout/fragment_upload_list.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
android:layout_centerInParent="true"
android:gravity="center"
android:text="@string/tv_no_uploads"
android:textSize="@dimen/text_size_20sp"
android:visibility="gone"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
Expand Down