Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#409 MyDashboardFragment is leaking bug fixed #410

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

#409 MyDashboardFragment is leaking bug fixed #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...main/java/org/wikiedufoundation/wikiedudashboard/ui/dashboard/view/MyDashboardFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class MyDashboardFragment : Fragment() {
private var mParam1: String? = null
private var mParam2: String? = null

private lateinit var myDashboardRecyclerAdapter: MyDashboardRecyclerAdapter
private var myDashboardRecyclerAdapter: MyDashboardRecyclerAdapter? = null

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
Expand Down Expand Up @@ -76,7 +76,7 @@ class MyDashboardFragment : Fragment() {

if (it.isNotEmpty()) {
recyclerCourseList?.visibility = View.VISIBLE
myDashboardRecyclerAdapter.setData(it)
myDashboardRecyclerAdapter?.setData(it)
textViewNoCourses?.visibility = View.GONE
} else {
recyclerCourseList?.visibility = View.GONE
Expand Down Expand Up @@ -122,7 +122,7 @@ class MyDashboardFragment : Fragment() {
val courseFilterQuery = dashboardViewModel.courseList.value.filterOrEmptyList {
it.title.toLowerCase(Locale.getDefault()).contains(query.toLowerCase(Locale.getDefault()))
}
myDashboardRecyclerAdapter.setData(courseFilterQuery)
myDashboardRecyclerAdapter?.setData(courseFilterQuery)
}

companion object {
Expand All @@ -147,4 +147,9 @@ class MyDashboardFragment : Fragment() {
this.arguments = args
}
}

override fun onDestroyView() {
myDashboardRecyclerAdapter = null
super.onDestroyView()
}
}