POC: Add email sender with API:Emailuser#1465
POC: Add email sender with API:Emailuser#1465suecarmol wants to merge 4 commits intoWikipediaLibrary:masterfrom
Conversation
katydidnot
left a comment
There was a problem hiding this comment.
Thanks! This looks like a great POC and works as expected, just had some minor nits.
|
Thanks for working on this!
I don't think these are intrinsic to the approach, just this implementation;
The need for that will be determined by the account that owns the bot;
I think we can add error handling for these things: https://www.mediawiki.org/wiki/API:Emailuser#Possible_errors I would suggest that we implement a warning email in TWLight for users that meet these cases; letting them know that if they want to continue to receive email from us (and participate in partners that require email), they need to change their wiki settings. We could either just prepend a warning banner template to every email for users that meet these conditions or add account flags to track the issue at login and have a separate command for sending a standalone email to impacted users. I think this mostly proves out the TWL engineering side of things; I think to close out this task, we get feedback on how to handle the above situations and figure out how we would want / need to do the on-wiki account setup for the bot owner. |
Description
versionitem in all docker-compose files (the warning was bothering me)Caveats from this approach:
Allow other users to email meoption set in Special:Preferences, then they will not receive an emailRationale
Our email sending system has issues when sending to certain accounts. This is a possible solution to that problem.
Phabricator Ticket
T383070
How Has This Been Tested?
Tested locally. You can run
python manage.py retrieve_monthly_usersand change thetargetparameter to your Wikipedia username.Screenshots of your changes (if appropriate):
Types of changes
What types of changes does your code introduce? Add an
xin all the boxes that apply: