Merged
Conversation
This action will periodically download the latest version of `language-data.json`, and replace the existing file in the repository. If the file has been updated, it will create a pull request to recommend merging the new changes. Bug: T404882
We can leverage the existing Django variables and functions instead of having to replace them all with custom ones in the models, views, and controllers.
The GitHub Action doesn't need to run as periodically anymore since the upstream `langugage-data.json` file doesn't seem to change that often.
suecarmol
approved these changes
Sep 23, 2025
Contributor
suecarmol
left a comment
suecarmol
left a comment
There was a problem hiding this comment.
I have pushed these changes to staging and reviewed the code, and everything seems to be working as expected. Thank you for your work on this!
katydidnot
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rewrote the
get_languages_from_locale_subdirectoriesfunction to handle bothLANGUAGESandLANGUAGES_BIDIdata, which keeps the rest of Django in sync better with thelanguage-data.jsonfile. Also updated the GitHub Action cron schedule to run monthly instead of daily.Rationale
Further work and improvements to T404882. These changes replace the original solution with something simpler and more integrated with the Django web framework.
Phabricator Ticket
https://phabricator.wikimedia.org/T404882
How Has This Been Tested?
Locally
Screenshots of your changes (if appropriate):
Types of changes
What types of changes does your code introduce? Add an
xin all the boxes that apply: