Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scan-sexps error for C-defined variables #336

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

LemonBreezes
Copy link
Contributor

This PR addresses #329.

@Wilfred
Copy link
Owner

Wilfred commented Jan 14, 2024

This feels wrong, considering that the file is in C mode. If you can get a unit test showing the fix works then we could merge this as-is, because we can then iterate from there :)

@LemonBreezes
Copy link
Contributor Author

This feels wrong, considering that the file is in C mode. If you can get a unit test showing the fix works then we could merge this as-is, because we can then iterate from there :)

Hi. I have not found a fix using the C syntax table but I added a test and comment for this fix.

@LemonBreezes LemonBreezes marked this pull request as ready for review January 23, 2024 21:32
@Wilfred Wilfred merged commit 4ba24ca into Wilfred:master Jun 13, 2024
4 checks passed
@Wilfred
Copy link
Owner

Wilfred commented Jun 13, 2024

Thanks for the PR, and sorry for the delay on getting this merged.

rennsax added a commit to rennsax/.emacs.d that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants