Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local dev tips #115

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Update local dev tips #115

merged 3 commits into from
Mar 29, 2024

Conversation

tdivoll
Copy link
Collaborator

@tdivoll tdivoll commented Mar 27, 2024

This makes it more clear that the Docker tips are specific to using the Cylc local pipeline, whereas the rest is for using the CLI local pipeline.

@tdivoll tdivoll added the documentation Improvements or additions to documentation label Mar 27, 2024
@tdivoll tdivoll self-assigned this Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (8aac9f5) to head (374f1a5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files           7        7           
  Lines         215      215           
=======================================
  Hits          204      204           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
@tdivoll
Copy link
Collaborator Author

tdivoll commented Mar 28, 2024

Also closes #118

Copy link
Collaborator

@danielmwatkins danielmwatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of strange this is showing here. Any idea why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's just from changing the permissions on the file. I think this is the change? 100644 → 100755 We weren't able to print the help on that file unless I changed it.

@tdivoll tdivoll merged commit e40bf7f into main Mar 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants