Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 8u131 and new URL scheme #60

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support 8u131 and new URL scheme #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7dcb669
Update java to u131
ag-gh May 2, 2017
ae3484f
Support for hashed URLs
ag-gh May 2, 2017
0463628
Make 8u131 the default
ag-gh May 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#

java_version: 8
java_subversion: 112
java_subversion: 131

java_download_path: /tmp
java_download_from_oracle: true
Expand Down
13 changes: 12 additions & 1 deletion tasks/set-role-variables.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@
#
# version-specific variables
#
- name: set internal vars for 1.8.0_131
set_fact:
jdk_version_detail: "{{ java_version }}u{{ java_subversion }}-b11"
jdk_tarball_hash: d54c1d3a095b4ff2b6607d096fa80163
when: java_version == 8 and java_subversion == 131
Copy link

@afeld afeld May 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about making these defaults, so that they can be overridden? That way, users can override when a new version is released.


- name: set internal vars for 1.8.0_112
set_fact:
jdk_version_detail: "{{ java_version }}u{{ java_subversion }}-b15"
Expand Down Expand Up @@ -130,8 +136,13 @@
- name: compose url for downloading file, if necessary
set_fact:
jdk_tarball_url: "http://download.oracle.com/otn-pub/java/jdk/{{ jdk_version_detail }}/{{ jdk_tarball_file }}"
when: jdk_version_detail is defined
when: jdk_version_detail is defined and jdk_tarball_hash is not defined


- name: compose url for downloading file, if necessary
set_fact:
jdk_tarball_url: "http://download.oracle.com/otn-pub/java/jdk/{{ jdk_version_detail }}/{{ jdk_tarball_hash }}/{{ jdk_tarball_file }}"
when: jdk_version_detail is defined and jdk_tarball_hash is defined

#
# JCE variables
Expand Down