Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract permission logic (isAdmin and validateIsTeamMember) #87

Open
jackbravo opened this issue Dec 10, 2022 · 0 comments
Open

Extract permission logic (isAdmin and validateIsTeamMember) #87

jackbravo opened this issue Dec 10, 2022 · 0 comments
Assignees
@maubarraganwize

Comments

@jackbravo
Copy link
Collaborator

We have some validations and permissions logic in app/models/project.server.ts in the function validateIsTeamMember(), that gets used in updateMembers() and updateProjecs(). This logic should probably be extracted to a separate validateHasPermissions() function that could be used instead in the action functions and loaders of edit and edit members pages. This was suggested by @LuisTejedaS here: #84 (comment)
@jackbravo jackbravo mentioned this issue Dec 10, 2022
Merged
3 tasks
@maubarraganwize maubarraganwize self-assigned this Jan 5, 2023
@maubarraganwize maubarraganwize mentioned this issue Jan 6, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maubarraganwize maubarraganwize

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jackbravo @maubarraganwize