Skip to content

Feat - 87 - Extract Permission Logic #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Conversation

maubarraganwize
Copy link
Contributor

What does this PR do?

Extracts permission logic from project.server.ts file to a separate file. Small bugfixes.

Where should the reviewer start?

app/models/project.server.ts
app/utils.ts

How should this be manually tested?

Go to Project page. Make sure that the page works correctly
Go to project members page (contributors) make sure the page works and saves correctly

Any background context you want to provide?

What are the relevant tickets?

#87

Screenshots

Questions

Checklist

  • I added the necessary documentation, if appropriate.
  • I added tests to prove that my fix is effective or my feature works.
  • I reviewed existing Pull Requests before submitting mine.

Copy link
Collaborator

@jackbravo jackbravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments. But as soon as they are solved, feel free to merge, they are minor I think.

@maubarraganwize maubarraganwize changed the title Feat - 87 - Extract Permission Logig Feat - 87 - Extract Permission Logic Jan 6, 2023
@maubarraganwize maubarraganwize merged commit 8b26398 into main Jan 6, 2023
@maubarraganwize maubarraganwize deleted the feat/87-permission-logic branch January 6, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants