Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/210/GitHub weekly participation by project #222

Merged
merged 14 commits into from
Oct 11, 2023
Merged

Feat/210/GitHub weekly participation by project #222

merged 14 commits into from
Oct 11, 2023

Conversation

martinrobled0
Copy link
Contributor

@martinrobled0 martinrobled0 commented Sep 26, 2023 •
edited
Loading

What does this PR do?

Get the weekly participation by project statistics of github.

How should this be manually tested?

  1. make sure at least one project has its repository url registered
  2. Run the get-gitprojects-activity script
  3. Go to Git hub info page of the project
  4. Check the statistics /github-info

Any background context you want to provide?

What are the relevant tickets?

#210

Screenshots

image

image

Questions

Checklist

  • I added the necessary documentation, if appropriate.
  • I added tests to prove that my fix is effective or my feature works.
  • I reviewed existing Pull Requests before submitting mine.

@martinrobled0 martinrobled0 marked this pull request as ready for review October 6, 2023 22:46
CarlosMilano
CarlosMilano reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@CarlosMilano CarlosMilano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good!

app/routes/projects/$projectId/github-info/index.tsx Show resolved Hide resolved
CarlosMilano
CarlosMilano approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@CarlosMilano CarlosMilano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

AxelUZ
AxelUZ approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@AxelUZ AxelUZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 👍

@martinrobled0 martinrobled0 merged commit e9a7484 into main Oct 11, 2023
@martinrobled0 martinrobled0 deleted the feat/210/GITHUB-weekly-participation-by-project branch October 11, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosMilano CarlosMilano CarlosMilano approved these changes

@AxelUZ AxelUZ AxelUZ approved these changes

@LuisTejedaS LuisTejedaS Awaiting requested review from LuisTejedaS

@jackbravo jackbravo Awaiting requested review from jackbravo

@maubarraganwize maubarraganwize Awaiting requested review from maubarraganwize

@PaolaSantolloV PaolaSantolloV Awaiting requested review from PaolaSantolloV

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinrobled0 @AxelUZ @CarlosMilano