Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - 231 - Fix status and tier project filters #238

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

maubarraganwize
Copy link
Contributor

What does this PR do?

Fixes status and tier project filters that were not working correctly

Where should the reviewer start?

app/routes/projects/index.tsx

How should this be manually tested?

Go to project page and make sure the filters now work correctly

What are the relevant tickets?

Ticket 231

Screenshots

Questions

Checklist

  • I added the necessary documentation, if appropriate.
  • I added tests to prove that my fix is effective or my feature works.
  • I reviewed existing Pull Requests before submitting mine.

Copy link
Contributor

@martinrobled0 martinrobled0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, just merge main 😄

/>
)}
{tierFacets.length > 0 && (
<FilterAccordion
title="Innovation tiers"
filter="tier"
items={statusFacets}
items={tierFacets}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@martinrobled0
Copy link
Contributor

martinrobled0 commented Oct 11, 2023

LGTM!, just merge main 😄

I think that you've already done it

@martinrobled0 martinrobled0 merged commit 818a22e into main Oct 11, 2023
@martinrobled0 martinrobled0 deleted the fix/231/fix-status-tier-filters branch October 11, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants