Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat - 207- Profile Page Changes #257

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Conversation

maubarraganwize
Copy link
Contributor

@maubarraganwize maubarraganwize commented Oct 25, 2023

What does this PR do?

  • Modify the page to show profile information from our DB profile table. This will show information synced from datalake
  • Show the projects the user is currently involved in
  • Allow the user to specify its Github user name
  • After saving the user name, retrieve the user info and repos from Github and populate the corresponding tables.

UPDATE:

  • Only allow profile owner and Admins to edit Github username
  • Made projects clickable
  • Added link in profiles list to profile detail page

Where should the reviewer start?

app/routes/profile/$email/index.tsx

How should this be manually tested?

Log in and go to the Profile page
Edit the github username and save

Any background context you want to provide?

What are the relevant tickets?

Ticket 207

Screenshots

Before: Without Github data:
image

Before: With Github data:
image

After:
image

Questions

Checklist

  • I added the necessary documentation, if appropriate.
  • I added tests to prove that my fix is effective or my feature works.
  • I reviewed existing Pull Requests before submitting mine.

@martinrobled0
Copy link
Contributor

Maybe we could block some parts of the ui when the status it's terminated
image

@martinrobled0
Copy link
Contributor

Maybe we could block some parts of the ui when the status it's terminated image

and in this case I clicked the edit button and then clicked save and the page was redirected to my profile.
image

Copy link
Contributor

@martinrobled0 martinrobled0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments

Copy link
Contributor

@CarlosMilano CarlosMilano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same as martin

@martinrobled0
Copy link
Contributor

Now if I try to edit someone else profile I get this
image

@martinrobled0
Copy link
Contributor

Now if I try to edit someone else profile I get this image

I fact, Is it okay that I can edit other people's profiles and comment the experience part?

Copy link
Contributor

@martinrobled0 martinrobled0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinrobled0 martinrobled0 merged commit 4283bbb into main Nov 7, 2023
7 checks passed
@martinrobled0 martinrobled0 deleted the feat/207/profile-page-changes branch November 7, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants