-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat - 207- Profile Page Changes #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same as martin
…n profile list page
…t/207/profile-page-changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
UPDATE:
Where should the reviewer start?
app/routes/profile/$email/index.tsx
How should this be manually tested?
Log in and go to the Profile page
Edit the github username and save
Any background context you want to provide?
What are the relevant tickets?
Ticket 207
Screenshots
Before: Without Github data:
Before: With Github data:
After:
Questions
Checklist