feat: change tab icon #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change the tab icon and fixed the skill filter error from the cards
Where should the reviewer start?
app/core/components/ProposalCard/index.tsx
How should this be manually tested?
To test the tab icon, you should see it at any page
To test the filter issue,..
1.- Click in a skill of any card
Any background context you want to provide?
Change the tab icon
What are the relevant tickets?
https://github.com/orgs/wizeline/projects/41/views/1?pane=issue&itemId=26713549
Screenshots
Before
After
Questions
Checklist