Add new columns to perfile table #305 #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackbravo
reviewed
Jun 11, 2024
app/models/profile.server.ts
Outdated
| @@ -8,7 +8,9 @@ import type { | |||
| PrismaClient, | |||
| } from "@prisma/client"; | |||
| import { Prisma } from "@prisma/client"; | |||
| import { sql } from "kysely"; | |||
There was a problem hiding this comment.
none of these changes from lines 11 to 13 seem necessary. ESLint says we are importing but not using those names.
There was a problem hiding this comment.
I think you revert line 11. It still shows this warning from ESLint
s
Outdated
There was a problem hiding this comment.
What is this file? Is it necessary?
Outdated
There was a problem hiding this comment.
What is this file? Is it necessary?
jackbravo
reviewed
Jun 11, 2024
app/models/profile.server.ts
Outdated
| @@ -8,7 +8,9 @@ import type { | |||
| PrismaClient, | |||
| } from "@prisma/client"; | |||
| import { Prisma } from "@prisma/client"; | |||
| import { sql } from "kysely"; | |||
There was a problem hiding this comment.
I think you revert line 11. It still shows this warning from ESLint
There was a problem hiding this comment.
have you tested these changes? You need to run
npm run migrate-profiles-lake
jackbravo
reviewed
Jun 20, 2024
app/lake.server.tsx
Outdated
| @@ -41,6 +42,7 @@ export async function getActiveProfiles() { | |||
| const query = `SELECT contact__wizeos_profile_id, contact__employee_number, contact__email, | |||
| contact__first_name, contact__preferred_name, contact__last_name, | |||
| contact__photo__url, | |||
| contact__isBillable, | |||
There was a problem hiding this comment.
I think this one is incorrect? Right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the column isBillable of type boolean with the default value true to the profiles table
Where should the reviewer start?
In the schema and in the Prisma migrations
How should this be manually tested?
With a query to the database