fix sonarlint warnings and issues from review

WoWs-Builder-Team · Oct 14, 2023 · 69866f7 · 69866f7
1 parent 039ad41
commit 69866f7
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 6 deletions.
diff --git a/WoWsShipBuilder.Data.Generator.Test/AssertionMethodAttribute.cs b/WoWsShipBuilder.Data.Generator.Test/AssertionMethodAttribute.cs
@@ -0,0 +1,8 @@
+using System;
+
+namespace WoWsShipBuilder.Data.Generator.Test;
+
+[AttributeUsage(AttributeTargets.Method)]
+public class AssertionMethodAttribute : Attribute
+{
+}
diff --git a/WoWsShipBuilder.Data.Generator.Test/DataElementAnalyzerTests/DataElementAnalyzerTest.cs b/WoWsShipBuilder.Data.Generator.Test/DataElementAnalyzerTests/DataElementAnalyzerTest.cs
@@ -34,6 +34,7 @@ public partial record TestRecord : DataContainerBase
         await CreateTest(source).RunAsync();
     }
 
+    [AssertionMethod]
     private static CSharpAnalyzerTest<DataElementAnalyzer, NUnitVerifier> CreateTest(string source)
     {
         const string baseClass = """

diff --git a/WoWsShipBuilder.Data.Generator.Test/DataElementAnalyzerTests/KeyValueUnit.cs b/WoWsShipBuilder.Data.Generator.Test/DataElementAnalyzerTests/KeyValueUnit.cs
@@ -114,7 +114,7 @@ namespace Test;
                      [DataContainer]
                      public partial record TestRecord : DataContainerBase
                      {
-                         [DataElementType(DataElementTypes.KeyValueUnit, UnitKey = "Test", ArgumentsTextKind = TextKind.LocalizationKey)]
+                         [DataElementType(DataElementTypes.KeyValueUnit, UnitKey = "Test", ArgumentsTextKind = TextKind.AppLocalizationKey)]
                          public decimal {|SB1003:Prop1|} { get; set; }
                      }
                      """;

diff --git a/WoWsShipBuilder.Data.Generator.Test/DataElementGeneratorTests/DataElementGeneratorTest.cs b/WoWsShipBuilder.Data.Generator.Test/DataElementGeneratorTests/DataElementGeneratorTest.cs
@@ -13,6 +13,7 @@ namespace WoWsShipBuilder.Data.Generator.Test.DataElementGeneratorTests;
 [SuppressMessage("Maintainability", "S2699", Justification = "false-positive since sonarlint does not recognize custom CreateTest method")]
 public partial class DataElementGeneratorTest
 {
+    [AssertionMethod]
     private static CSharpSourceGeneratorTest<DataElementGenerator.DataElementGenerator, NUnitVerifier> CreateTest(string source, string expected)
     {
         const string baseClass = """

diff --git a/...Builder.Data.Generator.Test/PropertyChangedGeneratorTests/PropertyChangedGeneratorTest.cs b/...Builder.Data.Generator.Test/PropertyChangedGeneratorTests/PropertyChangedGeneratorTest.cs
@@ -1,10 +1,12 @@
-using Microsoft.CodeAnalysis.CSharp.Testing;
+using System.Diagnostics.CodeAnalysis;
+using Microsoft.CodeAnalysis.CSharp.Testing;
 using Microsoft.CodeAnalysis.Testing.Verifiers;
 using WoWsShipBuilder.Data.Generator.PropertyChangedGenerator;
 
 namespace WoWsShipBuilder.Data.Generator.Test.PropertyChangedGeneratorTests;
 
 [TestFixture]
+[SuppressMessage("Maintainability", "S2699", Justification = "false-positive since sonarlint does not recognize RunAsync method from generator test framework")]
 public class PropertyChangedGeneratorTest
 {
     private const string AttributeClass = """

diff --git a/WoWsShipBuilder.Data.Generator/Utilities/SourceBuilder.cs b/WoWsShipBuilder.Data.Generator/Utilities/SourceBuilder.cs
@@ -11,7 +11,7 @@ internal sealed class SourceBuilder
 
   private readonly StringBuilder sb;
 
-  private int indent;
+  private int currentIndent;
 
   private LastAction lastAction;
 
@@ -141,13 +141,13 @@ private void BlockOpen(string? line = null)
 
   private SourceBuilder DecreaseIndent()
   {
-    --this.indent;
+    --this.currentIndent;
     return this;
   }
 
   private SourceBuilder IncreaseIndent()
   {
-    ++this.indent;
+    ++this.currentIndent;
     return this;
   }
 
@@ -174,7 +174,7 @@ private SourceBuilder Append(string? text)
 
   private SourceBuilder AppendIndent()
   {
-    this.sb.Append(' ', this.indent * IndentSize);
+    this.sb.Append(' ', this.currentIndent * IndentSize);
     return this;
   }