Update 2.3 (Desktop) #277
Merged
Update 2.3 (Desktop) #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace sonar.login with sonar.token due to the old version being deprecated
* initial draft for improved source gen * add tests for new generator and restructure generator project * keep ordering of data container properties in generated code * add data element analyzer and unittests, refactor data element generator * add new DataContainer attribute to data containers to enable new generator * update PropertyChangedSourceGenerator to use FAWMN * code cleanup for generators and analyzer * add TextKind type to better specify how a type should be treated * move data elements to reduce unnecessary namespace nesting * fix unittests after moving data elements to new namespace * fix tests for PropertyChangedGenerator * fix sonarlint warnings and issues from review
* Filters UI clean up * Initial work on ship comparison revamp * Implement #252 * revert ship stats panel chances * revert upgradedModulesUrlParameter * move loadSettings method code into vm constructor * change to use mudHidden instead of breakPointProvider to display filters * extract ship filter from ship comparison and fix wrapping #252 * fix nullability warning and improve margin for search box
* start reworking theme for web app #256 * more color scheme improvements, especially for dialogs * update ship comparison UI * extract theme creation to common project, minor theme tweaks * improvements from review * change talent panel elements color from info to primary * fix style for the talents activation button when talents and conditional modifiers are activated * Change the talent activation button style to match the one in the ship comparison page * minor theme improvements * update release notes for theme rework --------- Co-authored-by: iTTou <13366390+iTTou@users.noreply.github.com>
…updating url in ship stats page fixes #274
* update all json processing to use STJ instead of Newtonsoft * fix build deserialization * update to stable data structures and fix resulting errors also fix skill changes from update 12.10
* move settings link to regular navigation * move secondary range into main secondary expande * Remove detection from subs at maximum depth from concealment data container * swap positions of concealment and maneuverability datacontainer * add new translations * fix ShipStatsPanel.razor indentation * show "add new ship" when removing last ship on ships page * makes tabs header sticky * remove unnecessary css property * implement synchronization of expander stats in ship stats panel between multiple ship tabs * Apply requested changes * Move settings button on desktop in the same position as on web * add some visual improvements to make it easier to read ship's stats --------- Co-authored-by: floribe2000 <git@floribe2000.de>
* New translations translation.resx (French) * New translations translation.resx (Spanish) * New translations translation.resx (Danish) * New translations translation.resx (German) * New translations translation.resx (Hungarian) * New translations translation.resx (Italian) * New translations translation.resx (Japanese) * New translations translation.resx (Korean) * New translations translation.resx (Dutch) * New translations translation.resx (Polish) * New translations translation.resx (Russian) * New translations translation.resx (Turkish) * New translations translation.resx (Chinese Simplified) * New translations translation.resx (Chinese Traditional) * New translations translation.resx (Portuguese, Brazilian)
iTTou
approved these changes
Nov 10, 2023
yesod30
approved these changes
Nov 10, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.