-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix python packaging using latest methods #79
base: master
Are you sure you want to change the base?
Conversation
|
If I follow the latest python packaging guide (Link in Commit), this is the minimal change that was required. I just moved the sources to |
Got it, thanks for the explanation. |
The changes were required, as I mentioned in commit, to package it for debian and others. |
I would suggest do not merge it yet. because the setup.py needs to be cleaned. It would be highly appreciated if you could test the branch. just use |
I would also suggest while merging use the Squash and merge option rather than creating a new commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brlin-tw All changes are resolved. It might need virtualenv
and build
(on debian python3-virtualenv
and python3-build
) package to build.
@brlin-tw you can merge the branch. I have completed all the necessary changes and it works fine. |
@brlin-tw A gente reminder that the PR is ready for merge. Thank you. |
@brlin-tw Hi. Is this PR going to get merged or should I close this as incomplete? |
Hi @hsbasu, thanks for PR. |
- Change python packaging method following instructions from https://packaging.python.org/en/latest/tutorials/packaging-projects - Remove scripts as they can be created automatically from setup.cfg - move the sources to src - setup.py: remove captialization in package names, conflicts with other packaging methods like debian's - modify licence to gpl3+ - Add setup.cfg and pyproject.toml - modify MANIFEST.in to include assets - WoeUSB-ng.desktop: add version and change icon; fixes WoeUSB#11
2005857
to
f9d54c9
Compare
FYI, I use this PR without issue to build the aur package available at https://aur.archlinux.org/packages/woeusb-ng. The pkgbuild file that show the build process is available here. I'll subscribe to this thread to be notified about the merge to update the package. |
https://packaging.python.org/en/latest/tutorials/packaging-projects/
packaging methods like debian's