Newly Produced Ships - Name Fix Proof of Concept #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
New ships are not set to use historical names. They instead fall back to default values for the base game.
See the "Tirpitz" example here #199 (comment) as an example.
Solution
Use
name_groupincreate_equipment_variantfor the ships to match them up with a name in their ship name file.Testing
Create one of the ships that has a name update and verify it takes one of the defined names. You will likely have to select one of the outdated models.
NOTE: There is some existing bug with the "D9 class" of destroyers. Despite being listed as obsolete, it shows up in the naval production panel by default, and doesn't use the names provided. However, it also has an obsolete counter part which does use the names as expected. Fixing this bug is out of scope of this PR.... not sure how that is happening.
FYI @Wolferos @naashil