Apply suggestions from code review

Co-authored-by: Alexander Ebert <ebert@woltlab.com>
WoltLab · Oct 27, 2023 · 03e8dc1 · 03e8dc1
1 parent caf8783
commit 03e8dc1
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/wcfsetup/install/files/lib/system/user/authentication/password/algorithm/Pbkdf2.class.php b/wcfsetup/install/files/lib/system/user/authentication/password/algorithm/Pbkdf2.class.php
@@ -24,11 +24,10 @@ public function verify(
         string $hash
     ): bool {
         $parts = \explode(':', $hash, 5);
-        $hash = $parts[0];
-        $salt = $parts[1];
-        $algo = $parts[2];
-        $iterations = $parts[3];
-        $length = $parts[4];
+        if (\count($parts) !== 5) {
+            return false;
+        }
+        [$hash, $salt, $algo, $iterations, $length] = $parts;
 
         return \hash_equals($hash, \hash_pbkdf2($algo, $password, $salt, $iterations, $length));
     }
@@ -46,7 +45,7 @@ public function hash(
         $length = 32;
         $hash = \hash_pbkdf2($algo, $password, $salt, $iterations, $length);
 
-        return implode(':', [$hash, $salt, $algo, $iterations, $length]);
+        return \implode(':', [$hash, $salt, $algo, $iterations, $length]);
     }
 
     /**