Skip to content

Fix: PUT mentor api #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dricazenck merged 21 commits into from
Jan 26, 2026
Merged

Fix: PUT mentor api #460

dricazenck merged 21 commits into from
Jan 26, 2026

Conversation

@nycotin
Copy link
Contributor

@nycotin nycotin commented Jan 17, 2026 •
edited
Loading

Description

  • Fix issue with updating of mentorshipType
  • Apply fixes according to comments here: b88e3f7#r174911858

Screenshots

  • PUT Body
image
  • PUT response
image
  • GET updated mentor
image image

Change Type

  • Bug Fix
  • New Feature
  • Code Refactor
  • Documentation
  • Test
  • Other

Pull request checklist

Please check if your PR fulfills the following requirements:

@nycotin nycotin requested a review from a team as a code owner January 17, 2026 22:45
@nycotin
Copy link
Contributor Author

nycotin commented Jan 18, 2026 •
edited
Loading

  1. Added unit tests for PostgresMenteeSectionRepository only
  2. Adjusted MentorDto and removed reference to super.merge(), which was creating confusion on what has to be updated and invalidating the checks

What is currently not working as expected is the update of fields within objects (like menteeSection, skills, resources). In this case, MentorDto is only checking if they are empty, but it doesn't check in detail if each underlying field is empty or not and what to ignore for update. Therefore, if empty fields are provided within these objects, they will overwrite existing content.

If we want this, I wouldn't anyway include the checks in the MentorDto, but on the lower level (for ex, PostgressMenteeSectionReposiotory, PostgresMentorRepository). Let me know what you think!

nycotin and others added 3 commits January 21, 2026 20:42
@nycotin @dricazenck
Update src/main/java/com/wcc/platform/domain/platform/mentorship/Ment…
8cc43ed 
…or.java

Co-authored-by: Adriana Zencke Zimmermann <dricazenck@gmail.com>
@nycotin @dricazenck
Update src/main/java/com/wcc/platform/domain/platform/mentorship/Ment…
3fab175 
…orDto.java

Co-authored-by: Adriana Zencke Zimmermann <dricazenck@gmail.com>
@nycotin
Add missing imports
09ebeb8
@dricazenck
Copy link
Collaborator

dricazenck commented Jan 25, 2026

@nycotin could you update your branch and solve the conflicts so we can merge the changes?

@nycotin
Merge branch 'main' of https://github.com/nycotin/wcc-backend into fi…
02e5a5a 
…x-put-mentor-api

# Conflicts:
#	src/main/java/com/wcc/platform/domain/platform/mentorship/MentorDto.java
#	src/main/java/com/wcc/platform/repository/postgres/mentorship/PostgresMenteeSectionRepository.java
#	src/main/java/com/wcc/platform/service/MentorshipService.java
@nycotin
Add missing import
8b99f89
@nycotin
Copy link
Contributor Author

nycotin commented Jan 26, 2026

@dricazenck I have merged main and now I am getting quite some issue from pmdAll that are unrelated to what I have done for this branch:
image

There is also a refactoring of MentorshipServiceTest that will take me quite some time, so I am wondering if I wouldn't make more sense to just merge this so the fix is done and then take care the pmd issues/refactoring in another branch?

@dricazenck
Copy link
Collaborator

dricazenck commented Jan 26, 2026

@nycotin Looks like it is everything working from github actions with PMD and testing. So I will go ahead and merge. I will pull the changes locally to see what is going one. Thank you!! 🚀

@dricazenck dricazenck merged commit 1f6e1c8 into Women-Coding-Community:main Jan 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dricazenck dricazenck dricazenck approved these changes

@nverbic nverbic Awaiting requested review from nverbic nverbic is a code owner automatically assigned from Women-Coding-Community/backend-team

@wilsonadenuga wilsonadenuga Awaiting requested review from wilsonadenuga wilsonadenuga is a code owner automatically assigned from Women-Coding-Community/backend-team

@silkenodwell silkenodwell Awaiting requested review from silkenodwell silkenodwell is a code owner automatically assigned from Women-Coding-Community/backend-team

@nora-weisser nora-weisser Awaiting requested review from nora-weisser nora-weisser is a code owner automatically assigned from Women-Coding-Community/backend-team

@goelsonali goelsonali Awaiting requested review from goelsonali goelsonali is a code owner automatically assigned from Women-Coding-Community/backend-team

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nycotin @dricazenck