Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

47 team page #48

Merged
merged 24 commits into from
Jul 17, 2024
Merged

47 team page #48

merged 24 commits into from
Jul 17, 2024

Conversation

ann-kilzer
Copy link
Collaborator

@ann-kilzer ann-kilzer commented Jul 4, 2024

Resolves #47

What changed 🧐

Please list the changes that are in this PR

  • team page grid
  • team member card
  • Update team data (a few are still pending, but we can update in future PRs)

How did you test it? 🧪

  • unit tests
  • e2e tests

@ann-kilzer ann-kilzer self-assigned this Jul 4, 2024
@ann-kilzer ann-kilzer marked this pull request as ready for review July 5, 2024 16:00
@ann-kilzer ann-kilzer requested a review from sirbully as a code owner July 5, 2024 16:00
@ann-kilzer
Copy link
Collaborator Author

We don't have a dev build so playwright is currently failing... please test it locally to confirm.

public/Ann.png Outdated Show resolved Hide resolved
Copy link
Contributor

@sirbully sirbully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to add all the leadership peeps before merging? Just wondering if this is still WIP/Draft if that is the case?

@ann-kilzer ann-kilzer requested a review from sirbully July 6, 2024 14:44
@ann-kilzer
Copy link
Collaborator Author

Are you planning to add all the leadership peeps before merging? Just wondering if this is still WIP/Draft if that is the case?

People are responding at different times, so we can update in future PRs. I have placeholder images for now.

public/Ann.jpg Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirbully good call, I changed all images to JPG and it's way lighter

@@ -2,8 +2,6 @@ name: Playwright Tests
on:
push:
branches: [ main ]
pull_request:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly we have to dev environment, so playwright isn't going to be very reliable to automate here.

Copy link
Contributor

@sirbully sirbully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ann-kilzer ann-kilzer merged commit 0744e64 into main Jul 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Team Page
2 participants