56 close button fix tests #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann-kilzer
commented
Jul 17, 2024
| @@ -29,6 +29,8 @@ export default defineConfig({ | |||
| /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */ | |||
| trace: 'on-first-retry', | |||
| }, | |||
| outputDir: './playwright-report', | |||
There was a problem hiding this comment.
This will ensure our test results are saved when running in GitHub Actions
ann-kilzer
commented
Jul 17, 2024
| @@ -16,7 +16,7 @@ export default defineConfig({ | |||
| /* Fail the build on CI if you accidentally left test.only in the source code. */ | |||
| forbidOnly: !!process.env.CI, | |||
| /* Retry on CI only */ | |||
| retries: process.env.CI ? 2 : 0, | |||
| retries: process.env.CI ? 2 : 1, | |||
There was a problem hiding this comment.
It can be useful to retry once locally, also we will get saved traces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #56
What changed 🧐
useMediaQueryand test on mobile viewportsHow did you test it? 🧪
New unit tests, e2e tests, manual testing