Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility of page landmarks #2502

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

adamwoodnz
Copy link
Contributor

Fixes the page landmarks so that the main and footer landmarks are adjacent, which is ideal for accessibility.

See https://wordpress.slack.com/archives/C01KC5VDQBC/p1717552327365119?thread_ts=1717455021.461299&cid=C01KC5VDQBC

Depends on WordPress/wporg-mu-plugins#620

Fixes #2501

@adamwoodnz adamwoodnz added [Type] Bug Something isn't working on the Learn website. Accessibility Fix or enhancement related to accessibility. Dev labels Jun 5, 2024
@adamwoodnz adamwoodnz added this to the Learning Pathways launch milestone Jun 5, 2024
@adamwoodnz adamwoodnz self-assigned this Jun 5, 2024
@adamwoodnz adamwoodnz merged commit 3f9f9d5 into trunk Jun 5, 2024
1 check passed
@adamwoodnz adamwoodnz deleted the fix/2501-page-landmarks branch June 5, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Fix or enhancement related to accessibility. Dev [Type] Bug Something isn't working on the Learn website.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove markup between landmarks
1 participant