Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylish Press: use login and plugin shorthand #115

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

bph
Copy link
Collaborator

@bph bph commented Feb 4, 2025

Fixes #99

uses login and plugin shorthand

after first test, the landingPage /shop/ 404 so I change it to the shop page /contact-us/

Copy link

github-actions bot commented Feb 4, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@bph
Copy link
Collaborator Author

bph commented Feb 4, 2025

I experimented to have the siteOptions as shorthand but ran into 'problems' as to expected value types, and went back using the setSiteOptions step.
Screenshot 2025-02-04 at 18 18 28

Copy link
Contributor

@bgrgicak bgrgicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bph! Let's take a look at the landing page separately.

@bph bph merged commit 6c8d8d0 into trunk Feb 6, 2025
2 checks passed
@bph bph deleted the update-stylish-press branch February 6, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update `Stylish Press! to use the shorthand for login and plugins
2 participants