Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wp_add_inline_script for createBlockTheme object #428

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Use wp_add_inline_script for createBlockTheme object #428

merged 2 commits into from
Aug 14, 2023

Commits on Aug 14, 2023

  1. Use wp_add_inline_script for createBlockTheme obj 

    This change ensures we follow accepted good practices, as
`wp_localize_script` should only be used when localizing strings.

It's more verbose, but it doesn't lend itself to confusion.

Relevant comment: https://developer.wordpress.org/reference/functions/wp_localize_script/#comment-3213
    Vicente Canales committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    6fa6d13 View commit details
    Browse the repository at this point in the history

  2. Make sure to not change load order 

    Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com>
    @mikachan
    Vicente Canales and mikachan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    80c1dc7 View commit details
    Browse the repository at this point in the history