[I18n] Fix plugin internationalization #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcanales
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
This is a great improvement; thanks for taking the time to implement it @pedro-mendoca!
We should address any further improvements and as a follow-up, in order to get translations out ASAP.
You mentioned in slack that /assets/boilerplate/theme.json isn't being parsed; we should add an issue to get to that later.
Salve for the small naming nitpick, this is good to go.
| @@ -223,7 +223,10 @@ public static function create_admin_form_page() { | |||
| } | |||
|
|
|||
| public static function form_script() { | |||
There was a problem hiding this comment.
This is a great catch; it was frustrating me quite a bit, as it wasn't working with the extra / present.
It's working for me now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses many i18n issues:
wp_set_script_translations()to translate JavaScript scriptsSolves issue reported on https://wordpress.org/support/topic/the-screen-manage-theme-fonts-is-not-translated/