Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set page titles that set only within CBT #479

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Set page titles that set only within CBT #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions admin/class-manage-fonts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,25 +31,41 @@ function create_admin_menu() {
return;
}

$manage_font_page_slug = 'manage-fonts';
$add_google_font_page_slug = 'add-google-font-to-theme-json';
$add_local_font_page_slug = 'add-local-font-to-theme-json';

$manage_fonts_page_title = _x( 'Manage Theme Fonts', 'UI String', 'create-block-theme' );
$manage_fonts_menu_title = $manage_fonts_page_title;
add_theme_page( $manage_fonts_page_title, $manage_fonts_menu_title, 'edit_theme_options', 'manage-fonts', array( 'Fonts_Page', 'manage_fonts_admin_page' ) );
add_theme_page( $manage_fonts_page_title, $manage_fonts_menu_title, 'edit_theme_options', $manage_font_page_slug, array( 'Fonts_Page', 'manage_fonts_admin_page' ) );

// Check if the admin page title is set, and if not, set one.
// This is needed to avoid a warning in the admin menu, due to the admin page title not being set in
// the add_submenu_page() function for the Google Fonts and Local Fonts pages.
global $title;
if ( ! isset( $title ) ) {

// Check if current admin page is a create block theme page.
// Context: https://github.com/WordPress/create-block-theme/issues/478
$admin_page = isset( $_GET['page'] ) ? sanitize_text_field( wp_unslash( $_GET['page'] ) ) : '';
$manage_font_pages = array(
$manage_font_page_slug,
$add_google_font_page_slug,
$add_local_font_page_slug,
);

$is_manage_fonts_page = in_array( $admin_page, $manage_font_pages, true );

if ( ! isset( $title ) && $is_manage_fonts_page ) {
$title = $manage_fonts_page_title;
}

$google_fonts_page_title = _x( 'Embed Google font in the active theme', 'UI String', 'create-block-theme' );
$google_fonts_menu_title = $google_fonts_page_title;
add_submenu_page( '', $google_fonts_page_title, $google_fonts_menu_title, 'edit_theme_options', 'add-google-font-to-theme-json', array( 'Google_Fonts', 'google_fonts_admin_page' ) );
add_submenu_page( '', $google_fonts_page_title, $google_fonts_menu_title, 'edit_theme_options', $add_google_font_page_slug, array( 'Google_Fonts', 'google_fonts_admin_page' ) );

$local_fonts_page_title = _x( 'Embed local font in the active theme', 'UI String', 'create-block-theme' );
$local_fonts_menu_title = $local_fonts_page_title;
add_submenu_page( '', $local_fonts_page_title, $local_fonts_menu_title, 'edit_theme_options', 'add-local-font-to-theme-json', array( 'Local_Fonts', 'local_fonts_admin_page' ) );
add_submenu_page( '', $local_fonts_page_title, $local_fonts_menu_title, 'edit_theme_options', $add_local_font_page_slug, array( 'Local_Fonts', 'local_fonts_admin_page' ) );
}

function has_file_and_user_permissions() {
Expand Down
Loading