Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic property deprecation #501

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix dynamic property deprecation #501

merged 1 commit into from
Jan 4, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Jan 4, 2024

This PR fixes a warning error that occurs when performing actions to download a zip file. This issue occurs when PHP version is 8.2 or higher and WP_DEBUG is enabled.

Dynamic properties are deprecated in PHP 8.2 and will cause a critical error in 9.0. Therefore, the properties must be declared in advance. This issue is also discussed in the core ticket.

67fe8b996e6e71f80e6d51485a0708f7.mp4

This PR should fix errors that occur in the following three actions:

  • Export {theme name}
  • Create child of {theme name}
  • Clone {theme name}

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @t-hamano!

@mikachan mikachan merged commit fcc9a1c into WordPress:trunk Jan 4, 2024
1 check passed
@t-hamano t-hamano deleted the fix/dynamic-prop-deprecation branch February 27, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants