Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hardcoded wp-admin URLs #576

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix hardcoded wp-admin URLs #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion admin/create-theme/theme-form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public static function create_admin_form_page() {
printf(
/* translators: %s: editor link. */
esc_html__( 'This page is deprecated and will be removed in the next release. Please try exporting from the Create Block Theme menu of the %s instead.', 'create-block-theme' ),
' <a href="' . esc_url( '/wp-admin/site-editor.php?canvas=edit' ) . '">' . __( 'editor', 'create-block-theme' ) . '</a>'
' <a href="' . esc_url( admin_url( 'site-editor.php?canvas=edit' ) ) . '">' . __( 'editor', 'create-block-theme' ) . '</a>'
);
?>
</p>
Expand Down
7 changes: 5 additions & 2 deletions src/manage-fonts/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
// Submit the form to the server
manageFontsFormElement.submit();
}
}, [ newThemeFonts ] );

Check warning on line 54 in src/manage-fonts/index.js

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useEffect has missing dependencies: 'fontToDelete.fontFamily' and 'manageFontsFormElement'. Either include them or remove the dependency array

const toggleIsHelpOpen = () => {
setIsHelpOpen( ! isHelpOpen );
Expand Down Expand Up @@ -240,14 +240,17 @@
{
a: (
// eslint-disable-next-line jsx-a11y/anchor-has-content
<a href="/wp-admin/site-editor.php?canvas=edit" />
<a href="site-editor.php?canvas=edit" />
),
}
) }
</p>
<img
src="https://i0.wp.com/wordpress.org/news/files/2024/04/Font-Manager-2.png?w=620&ssl=1"
alt="WordPress 6.5 Font Library"
alt={ __(
'WordPress 6.5 Font Library',
'create-block-theme'
) }
Comment on lines -250 to +253
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fix

/>
<p>
{ createInterpolateElement(
Expand Down
Loading