-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package-lock.json #620
Conversation
@@ -11,7 +11,6 @@ | |||
"dependencies": { | |||
"@codemirror/lang-json": "^6.0.1", | |||
"@uiw/react-codemirror": "^4.21.24", | |||
"@wordpress/env": "^9.9.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package is installed as devDependencies
in package.json
. Therefore, it is unclear why it existed as dependencies
in package-lock.json
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the testing. I tried regenerating |
Yes, although not as many differences - the difference with
Yes, I see a lot of changes in my package-lock on trunk. |
Yes, I would appreciate it if you could push it. Your Node version is 20, right? |
I've just pushed it here: 3a65a35
Yes, I'm using v20.12.2. |
Check out the latest commits on this branch and I tried running |
My npm version is v10.5.0 too! I'm happy to go with your package-lock version, I don't think it's a big deal, but it's confusing why they're different 😅 |
I don't understand why there is a difference since the npm version and node version are exactly the same 😅 I tried regenerating
If it doesn't resolve the issue, it might be better to close this PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests fine for me.
Installed dependencies from scratch and the lock file remains unchanged.
I'm keen to bring this in.
I noticed that when I run
npm ci
on the latest trunk,package-lock.json
gets updated. I think this is because only@wordpress/env
inpackage.json
was updated in #619.Testing Instructions
npm i
.git diff