Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Version field not updated #640

Closed
wants to merge 2 commits into from
Closed

Conversation

t-hamano
Copy link
Contributor

I noticed that the version field was not taken into account in the sanitize_theme_data method, so we couldn't update this field.

image

This PR should also resolve the following PHP error that is logged when updating metadata.

PHP Warning:  Undefined array key "version" in /var/www/html/wp-content/plugins/create-block-theme/admin/create-theme/theme-styles.php on line 20

Testing Instructions

  • Opne the Edit Theme Metadata modal.
  • Update "Version" field.
  • Open style.css in your active theme and check the Version: header data.

@pbking
Copy link
Contributor

pbking commented May 15, 2024

I've fixed the same in this PR which also fixes some other values that get clobbered.

@t-hamano t-hamano closed this May 16, 2024
@pbking pbking deleted the fix/metadata-version-update branch May 16, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants