Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Improve color contrast for help button #672

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

t-hamano
Copy link
Contributor

The text color for the help button is $gray-600, which meets accessibility requirements for large text, but not for normal text. For normal text, we should use a color at least darker than $gray-700.

Or, we could just leave it as the normal text color.

Before ($gray-600, #949494) After ($gray-700, #757575)
image image
image image

Comment on lines -34 to -36
&__about-button svg {
fill: $gray-600;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @t-hamano! I think using $gray-700 is a good change and seems like a suitable contrast for this font size.

@t-hamano t-hamano merged commit 93fafc7 into trunk Jun 17, 2024
2 checks passed
@t-hamano t-hamano deleted the i11y/help-button-color branch June 17, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants