Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize DOS (Windows) new line style on readme.txt #681

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Sanitize DOS (Windows) new line style on readme.txt #681

merged 2 commits into from
Jul 3, 2024

Conversation

matiasbenedetto
Copy link
Contributor

@matiasbenedetto matiasbenedetto commented Jul 3, 2024 •
edited
Loading

What?

Replaces DOS new line style on readme.txt

Why?

This type of character causes problems on WordPress.org theme directory.

Reference from a theme review:

Both DOS and UNIX style line endings were found in the file readme.txt. This causes a problem with SVN repositories and must be corrected before the theme can be accepted.

Fixes #680

How?

The "\r\n" new line characters are replaced by the unix style new line character "\n" when creating or updating a readme.txt text.

@matiasbenedetto matiasbenedetto added the bug Something isn't working label Jul 3, 2024
@matiasbenedetto matiasbenedetto mentioned this pull request Jul 3, 2024
Closed
mikachan
mikachan approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this! Code looks good to me and it's testing well. I think we can bring this in 🎉

@matiasbenedetto matiasbenedetto merged commit 082be0b into trunk Jul 3, 2024
2 checks passed
@matiasbenedetto matiasbenedetto deleted the add/sanitize-dos-newlines branch July 3, 2024 13:59
@MaggieCabrera MaggieCabrera mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikachan mikachan mikachan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Create Block Theme Release Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Theme Check plugin sometimes returns "Both DOS and UNIX style line endings" error
2 participants
@matiasbenedetto @mikachan