Lodash: Refactor away from _.pick() (#45946)

WordPress · Nov 25, 2022 · 15610be · 15610be
1 parent 80c68fd
commit 15610be
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -143,6 +143,7 @@ module.exports = {
 							'overEvery',
 							'partial',
 							'partialRight',
+							'pick',
 							'random',
 							'reduce',
 							'reject',

diff --git a/packages/babel-plugin-makepot/index.js b/packages/babel-plugin-makepot/index.js
@@ -33,7 +33,7 @@
  */
 
 const { po } = require( 'gettext-parser' );
-const { pick, isEqual, merge, isEmpty } = require( 'lodash' );
+const { merge, isEmpty } = require( 'lodash' );
 const { relative, sep } = require( 'path' );
 const { writeFileSync } = require( 'fs' );
 
@@ -182,10 +182,7 @@ function isValidTranslationKey( key ) {
  * @return {boolean} Whether valid translation keys match.
  */
 function isSameTranslation( a, b ) {
-	return isEqual(
-		pick( a, VALID_TRANSLATION_KEYS ),
-		pick( b, VALID_TRANSLATION_KEYS )
-	);
+	return VALID_TRANSLATION_KEYS.every( ( key ) => a[ key ] === b[ key ] );
 }
 
 /**