Feedback suggestions from review:

add overrides to dep array in Editor Styles rename hook
WordPress · Jun 25, 2024 · fab458f · fab458f
1 parent f1c92dc
commit fab458f
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/packages/block-editor/src/components/editor-styles/index.js b/packages/block-editor/src/components/editor-styles/index.js
@@ -113,7 +113,7 @@ function EditorStyles( { styles, scope, overrides } ) {
 				.map( ( style ) => style.assets )
 				.join( '' ),
 		];
-	}, [ styles, styleOverrides, scope ] );
+	}, [ styles, styleOverrides, overrides, scope ] );
 
 	return (
 		<>

diff --git a/packages/block-editor/src/hooks/block-style-variation.js b/packages/block-editor/src/hooks/block-style-variation.js
@@ -68,7 +68,7 @@ function getVariationNameFromClass( className, registeredStyles = [] ) {
  * @param {Object} config A global styles object, containing settings and styles.
  * @return {Array} An array of new block variation overrides.
  */
-export function useUpdateBlockVariationOverridesWithConfig( config ) {
+export function useUpdateBlockStyleVariationOverridesWithConfig( config ) {
 	const overrides = useSelect(
 		( select ) => unlock( select( blockEditorStore ) ).getStyleOverrides(),
 		[]

diff --git a/packages/block-editor/src/hooks/index.js b/packages/block-editor/src/hooks/index.js
@@ -88,4 +88,4 @@ export { getTypographyClassesAndStyles } from './use-typography-props';
 export { getGapCSSValue } from './gap';
 export { useCachedTruthy } from './use-cached-truthy';
 export { useZoomOut } from './use-zoom-out';
-export { useUpdateBlockVariationOverridesWithConfig } from './block-style-variation';
+export { useUpdateBlockStyleVariationOverridesWithConfig } from './block-style-variation';
diff --git a/packages/block-editor/src/private-apis.js b/packages/block-editor/src/private-apis.js
@@ -23,7 +23,7 @@ import { BlockRemovalWarningModal } from './components/block-removal-warning-mod
 import {
 	useLayoutClasses,
 	useLayoutStyles,
-	useUpdateBlockVariationOverridesWithConfig,
+	useUpdateBlockStyleVariationOverridesWithConfig,
 } from './hooks';
 import DimensionsTool from './components/dimensions-tool';
 import ResolutionTool from './components/resolution-tool';
@@ -92,5 +92,5 @@ lock( privateApis, {
 	PrivatePublishDateTimePicker,
 	useSpacingSizes,
 	useBlockDisplayTitle,
-	useUpdateBlockVariationOverridesWithConfig,
+	useUpdateBlockStyleVariationOverridesWithConfig,
 } );
diff --git a/packages/edit-site/src/components/revisions/index.js b/packages/edit-site/src/components/revisions/index.js
@@ -25,7 +25,7 @@ const {
 	ExperimentalBlockEditorProvider,
 	GlobalStylesContext,
 	useGlobalStylesOutputWithConfig,
-	useUpdateBlockVariationOverridesWithConfig,
+	useUpdateBlockStyleVariationOverridesWithConfig,
 } = unlock( blockEditorPrivateApis );
 const { mergeBaseAndUserConfigs } = unlock( editorPrivateApis );
 
@@ -35,7 +35,7 @@ function isObjectEmpty( object ) {
 
 function RevisionStyles( { styles, config } ) {
 	const mergedOverrides =
-		useUpdateBlockVariationOverridesWithConfig( config );
+		useUpdateBlockStyleVariationOverridesWithConfig( config );
 
 	return <EditorStyles styles={ styles } overrides={ mergedOverrides } />;
 }